search

SubhamTyagi / android-ocr

Tesseract based OCR for android
Apache License 2.0
401 stars 67 forks source link

Fastlane directory uses invalid names for some locales #24

Closed bene64 closed 3 years ago

bene64 commented 3 years ago

Fastlane uses BCP47 locale tags, which use a - as the separator rather than _. There are a number of locales that use the _ here. Please rename those dirs to use -. Thanks!

For reference: F-Droid downstream issue.

SubhamTyagi commented 3 years ago

Translation is done via Weblate and These directories also created by Weblate. It seems that this issue is related to Weblate App store meta data files file format. I can also change the directory name but when someone adds new language then it will fails hence You should also create a issue there.

bene64 commented 3 years ago

Thanks for that hint, we'll have a look into it.

eighthave commented 3 years ago

There is an issue filed for Weblate here https://github.com/WeblateOrg/weblate/issues/5522. Weblate's part in this was using the wrong separator, that's fixed. As for choosing the right locale tags for Google Play, that's currently up to the app dev, or Fastlane if you use that, since Google Play has strange rules and changes them sometimes. F-Droid will use any valid BCP47 locale tag.

SubhamTyagi commented 3 years ago

Weblate's part in this was using the wrong separator, that's fixed.

So I have to rename that language directory (Currently only one 😃 )