search

SubhamTyagi / openinwa

Create chat in WhatsApp without saving number to your phonebook
GNU General Public License v3.0
83 stars 30 forks source link

Switch to library for number field and country picker #8

Closed ialokim closed 5 years ago

ialokim commented 5 years ago

As the primary purpose of this app is not the phone number validation, I would suggest to replace the hard-coded, built-in country code picker and the phone number field by the library android-phone-field. It already provides most of the functionality your forked android-phone-number-with-flags supports. This change would facilitate a better separation between the app's own code and code that is just necessary for the phone input field.

@SubhamTyagi If you are okay with this, I would be willing to look into the migration.

SubhamTyagi commented 5 years ago

i am not also happy with current version of phone number validation.

there is also some difficulty in pasting of number. i have assigned this issue to you when you have done you can close this issue

SubhamTyagi commented 5 years ago

i think mherod fork and premisedata fork of original repo are currently maintained.