search

SubhojeetDas1107 / GameZone

Contribute on this repository with VALID PRs to HACKTOBERFEST-2022 and earn amazing swags!
https://github-gamezone.netlify.app/
MIT License
13 stars 14 forks source link

Add background music to games #17

Open SubhojeetDas1107 opened 2 years ago

Dhruv1969Karnwal commented 2 years ago

i can do it, please assign it to me sir

SubhojeetDas1107 commented 2 years ago

Okay... Assigned

amnindersingh12 commented 2 years ago

Hi @SubhojeetDas1107, regarding background music. Do you wish to autoplay music, after user have entered the gamezone? And continue playing music until user lefts the website. Do you have any audio file in mind that you want to play, or should I choose any soft free music ?

I have this one in mind. audio

robin6717 commented 2 years ago

Hi,

Sorry to bother you with this but I am wondering something..

On the README.md of your gamezone repo, there is a Link to go to the GAMEZONE..

And when I go there and then go to my blackjack game, the css and js are not working.. but in my ( up to date ) repo it is working....

Is the link to the gamezone an updated version of the Gamezone?

I try to understand why my blackjack is broken there....

Thank you for your feedback,

Robin

Van: Subhojeet Das @.> Verzonden: dinsdag 11 oktober 2022 14:37 Aan: SubhojeetDas1107/GameZone @.> CC: robin van steenbergen @.>; Comment @.> Onderwerp: Re: [SubhojeetDas1107/GameZone] Add background music to games (Issue #17)

Ok... Assigned to you

— Reply to this email directly, view it on GitHubhttps://github.com/SubhojeetDas1107/GameZone/issues/17#issuecomment-1274620531, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXKP7A6MUTMJQXET7SAQ7J3WCVNPHANCNFSM6AAAAAARCGKW7I. You are receiving this because you commented.Message ID: @.***>

robin6717 commented 2 years ago

aha I notice that the PR where I fixed this issue before ( I have a wrong reference to the css and js files in my html ) but the PR was not accepted yet. So at least I found out why it does not work yet 🙂

Maybe you can review my PR.

thank you and have a great day!

Robin

Van: Subhojeet Das @.> Verzonden: dinsdag 11 oktober 2022 14:37 Aan: SubhojeetDas1107/GameZone @.> CC: robin van steenbergen @.>; Comment @.> Onderwerp: Re: [SubhojeetDas1107/GameZone] Add background music to games (Issue #17)

Ok... Assigned to you

— Reply to this email directly, view it on GitHubhttps://github.com/SubhojeetDas1107/GameZone/issues/17#issuecomment-1274620531, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXKP7A6MUTMJQXET7SAQ7J3WCVNPHANCNFSM6AAAAAARCGKW7I. You are receiving this because you commented.Message ID: @.***>