search

Subito-it / PodBuilder

A tool to precompile CocoaPods pods
Other
284 stars 28 forks source link

Unable to prebuild libraries with module_name listed in podspec #61

Closed ryo-otake-sonix closed 2 years ago

ryo-otake-sonix commented 2 years ago

Issue

We have confirmed that libraries with module_name listed in podspec are not prebuilt anymore. (In PodBuilder 4.2.0 and 4.3.0) In this case, I have confirmed the libraries lottie-ios, ReachabilitySwift.

--- Log ---

In New Copy Phase, it seemed to be caused by the fact that the module_name directory was being detected whether it exists or not.

The directory actually generated was the directory of root_name, and the directory of module_name did not exist.

lottie-ios:  root_name -> lottie-ios,  module_name -> Lottie

ReachabilitySwift:  root_name -> ReachabilitySwift,  module_name -> Reachability

Therefore, it seems that 'Prebuilt items for xxx not found' was displayed and the later process was not done.

Libraries whose module_name was not listed in the podspec were prebuilt with no problems because they were detected by root_name.

What I have tried

I tried to prebuild by overriding the module_name value to the root_name value in PodBuilder.json, but the build failed during command execution and did not work.

--- PodBuilder.json ---

--- Error ---

Fixed points

As a result, I was able to confirm that it is possible to prebuild by passing root_name instead of module_name when generating the source_path.

--- Install.rb ---

--- Log ---

ryo-otake-sonix commented 2 years ago

@tcamin I tried to create a PR for this issue, but could not push the changes.

--- Log ---

Therefore, could you please check this issue?

tcamin commented 2 years ago

I released version 4.4.0 which I hope should fix the issue, let me know.

@tcamin I tried to create a PR for this issue, but could not push the changes.

FYI pull request should be opened from a fork, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork