search

SublimeLinter / SublimeLinter-eslint

This linter plugin for SublimeLinter provides an interface to ESLint
MIT License
865 stars 88 forks source link

Update README to add instructions about typescript #288

Closed ktaragorn closed 5 years ago

ktaragorn commented 5 years ago

Also clean up a bit.

kaste commented 5 years ago

Hi! Have you seen #287? We generally want to do this automatically. What would be the best dependency to look for. (We basically have a mapping from package to selector in that PR.)

karthikbeam commented 5 years ago

@kaste Nice, I would have expected that. @typescript-eslint should be the right plugin for this?

karthikbeam commented 5 years ago

specifically in package.json, the packages used are @typescript-eslint/eslint-plugin and @typescript-eslint/parser, in eslintrc it is declared as @typescript-eslint

kaste commented 5 years ago

I'll take the update here anyways. It's a good reference even if we need to rewrite the README after we land auto-selectors.

For #287, I go with '@typescript-eslint/parser': 'source.ts' for now since the parser is needed for eslint to actually read 'ts' files, and then on top of that you can have probably multiple ts linters. That's how I read their README at least.

ktaragorn commented 5 years ago

Sounds good, tnx!