SublimeLinter / SublimeLinter-flake8

SublimeLinter plugin for python, using flake8.
MIT License
184 stars 28 forks source link

Implement ignoring auto-fixable codes #95

Closed kaste closed 6 years ago

kaste commented 6 years ago

Fixes #65

braver commented 6 years ago

Do add something to the readme about this. The default should also be false, fixing white space isn’t on by default in Sublime Text.

kaste commented 6 years ago

Hm, probably better to first just check which 'fixers' are actually enabled. Added W292 support.

braver commented 6 years ago

Nifty!

kaste commented 6 years ago

BTW still think ignore_fixables should be False by default now that I actually check which of the fixers are on?

braver commented 6 years ago

On the fence really. Let’s go with True and see what happens.

kaste commented 6 years ago

Ok, this is now release candidate 4.2.0.

kaste commented 6 years ago

Erm, same code just added the documentation. Code is 3 months old, so it probably works.

kaste commented 6 years ago

You know, we don't need to rush through it

braver commented 6 years ago

I’m gonna play with this tomorrow, but am away next week (in the German forests far away from my laptop) so, I guess I’ll merge it when I get back?

braver commented 6 years ago

Flake8 is broken for me right now, so can't test: https://gitlab.com/pycqa/flake8/issues/437

kaste commented 6 years ago

That's a soft erred bc flake8 puts something on stderr if you use py37. The linter will still work. Anyway, fixed it!

We discussed this before, and thought flake will probably do a release as soon as py37 gets a final release. Nope, of course.

braver commented 6 years ago

Sweet!

braver commented 6 years ago

Ok, so I didn't give it a big workout, but it's really nice. Suppressing the FutureWarning stuff is super nice. Let's 🛥