Moved syntax attribute to use 'defaults'

SublimeLinter / SublimeLinter-rubocop

SublimeLinter 3 plugin for Ruby, using rubocop.

MIT License

159 stars 40 forks source link

Moved syntax attribute to use 'defaults' #59

Closed 1dustindavis closed 6 years ago

1dustindavis commented 6 years ago

Addresses #58 by replacing the syntax attribute with a selector within the defaults attribute as defined here: http://www.sublimelinter.com/en/stable/linter_settings.html#selector

braver commented 6 years ago

Thanks! Looks good to me. @kaste agree?

kaste commented 6 years ago

Yeah, definitely looks good to me. Thanks!

fschwahn commented 6 years ago

My html.erb-files are suddenly linted with rubocop, resulting in lots of linter errors (as erb templates are still unsupported in rubocop). I suspect this change is responsible for that?

braver commented 6 years ago

Probably. What is the root scope of such a file?

fschwahn commented 6 years ago

Sorry, I don't know what root scope means in this context?

braver commented 6 years ago

What does it say when you run "Show Scope Name" in one of those files?

fschwahn commented 6 years ago

text.html.ruby text.html.basic source.ruby.rails.embedded.html punctuation.definition.group.end.ruby