search

SublimeLinter / SublimeLinter-rubocop

SublimeLinter 3 plugin for Ruby, using rubocop.
MIT License
159 stars 40 forks source link

Use rvm if available #67

Closed kaste closed 5 years ago

kaste commented 5 years ago

Fixes #66

Remember: I don't have 'rvm' and can't test this, so any typo can break.

braver commented 5 years ago

I can’t test either, and no one in the community will. Two possible courses of action:

  1. push the change, see if anyone bothers to report the breakage, if any.
  2. close the PR. If no one in the community can be bothered to test the solution, the problem seems to be unimportant.

What do you wan to do? I vote no. 2.

katzer commented 5 years ago

I am using RVM. How to install the plugin based on this PR?

kaste commented 5 years ago

Hi @katzer! Just clone the repo and checkout the PR into your Packages folder. (into this one Preferences > Browse Packages)

katzer commented 5 years ago

It works!

katzer commented 5 years ago

I noticed that my root problem was that ST did not load my profile and correct PATH. Since its loading the login shell, there needs to be a ~/.zlogin, ~/bash_login, ... file. Other files like ~/zshrc or .bashrc won't work.

kaste commented 5 years ago

No risk no fun merge