search

SublimeText-Markdown / MarkdownEditing

Powerful Markdown package for Sublime Text with better syntax understanding and good color schemes.
MIT License
3.19k stars 649 forks source link

Uncolored link elements in 4107-3.1.0 #670

Closed GiovanH closed 2 years ago

GiovanH commented 2 years ago

Not sure if this is a bug or an intentional change. If it's an intentional change I would appreciate some guidance in how to manually revert the colors to their previous scheme.

Expected colors in 76342e69b4747839a772c547d39008d68073998a

image

Unexpected colors in ec66bbee7396a3fec10a29cfc0fa30ec073a4e91

image

deathaxe commented 2 years ago

The string scopes have been removed from link/image descriptions for three reasons:

  1. core Markdown syntax removed them long ago
  2. link descriptions may contain images/html and other markup. Scoping them string is not correct.
  3. string scope is something more common to source code. Everything in a Markdown document is basically text aka a string. So it doesn't make much sense to use it there.

You'd need to tweak your color scheme to get the colors back.

Example:

{
    "scope": "meta.image.inline.description.markdown, meta.image.reference.description.markdown, meta.link.inline.description.markdown, meta.link.reference.description.markdown, meta.link.reference.literal.description.markdown, meta.link.reference.wiki.description.markdown",
    "foreground": "var(--yellowish)"
},