search

SublimeText-Markdown / MarkdownEditing

Powerful Markdown package for Sublime Text with better syntax understanding and good color schemes.
MIT License
3.19k stars 649 forks source link

Mariana patch renders deleted text black-on-black #678

Closed reagle closed 2 years ago

reagle commented 2 years ago

Full discussion on ST Forum.

MarkdownEditing ships some patches for Monokai and Mariana to maintain old highlighting. The color for strikethrough obviously needs some tweaks. @deathaxe

reagle commented 2 years ago

I'm glad to see single tildas don't trigger strikeout, but is this what the new coloring is supposed to be? The current line highlighting makes the actual tildas difficult to see.

Screen Shot 2022-01-24 at 09 34 57
deathaxe commented 2 years ago

Actually didn't notice that as I turned line highlighting off.

reagle commented 2 years ago

Should we reopen? Or should I file a separate report? As I mentioned, I'm trying to stick with defaults as much as possible, and I think line highlighting is the default.

deathaxe commented 2 years ago

Already fixed it locally.

If you need a quick fix you could call "UI: Customize Color Scheme" and ...

{
    "rules": [
        {
            "name": "Markdown: Striked Punctuations",
            "scope": "text.html.markdown markup.strikethrough & (punctuation.definition | punctuation.separator | punctuation.definition.strikethrough | punctuation.definition.constant | punctuation.definition.image | punctuation.definition.link | punctuation.definition.metadata | markup.bold punctuation.definition.bold | markup.italic punctuation.definition.italic | string punctuation.definition.string)",
            "foreground": "var(blue6)",
            "font_style": ""
        },
    ]
}