search

SublimeText-Markdown / MarkdownEditing

Powerful Markdown package for Sublime Text with better syntax understanding and good color schemes.
MIT License
3.17k stars 649 forks source link

Allow blockquote visual style changes to be disabled so I can have my `>`'s back #741

Closed 0xdevalias closed 7 months ago

0xdevalias commented 7 months ago

Currently MarkdownEditing seems to visually change the leading >'s of a blockquote into a grey quote bar:

image

But I don't want my >'s replaced.. I want it to look like plaintext still:

image

While this is fine for something rendering markdown, it's absolutely not what I want while editing it; though I realise that others opinions on this will differ.

Since it's changing a default expectation people tend to have when editing a plaintext format like markdown; at the very least there should be an option that allows it to be disabled/overridden.

This doesn't seem to change between the colour schemes.

I tried to look through the code and figure out where/how to change this so I could contribute a fix, but I wasn't sure what part is even making this happen in the first place, so was unable to.

deathaxe commented 7 months ago

Duplicat of #659.

This behavior can be adjusted by customizing color scheme.

0xdevalias commented 7 months ago

This behavior can be adjusted by customizing color scheme.

Oh true.. Thanks for the old issue reference :)

Defining the same background/foreground for block quotes has been the default in MDE's color schemes for ages.

The only way to change that is to create an overriding color scheme (e.g.: Monokai.sublime-color-scheme) in your user package with redefined foreground/background colors.

{
  "rules": [

      // Block Quotes
      {
          "name": "Block Quotes",
          "scope": "text.html.markdown markup.quote punctuation.definition.blockquote, text.html.markdown markup.quote punctuation.definition.quote",
          "foreground": "var(white)",
          "background": "var(black3)"
      },
  ]
}

Originally posted by @deathaxe in https://github.com/SublimeText-Markdown/MarkdownEditing/issues/659#issuecomment-951126084

The color rules the symbol. The gray bar in screenshot 1 is still a > character, but with both forground and background color set to the same color. If you want to see the > char, you need to apply the proposed patch to a user defined color scheme override. The current style is "working as expected" and won't be changed.

Originally posted by @deathaxe in https://github.com/SublimeText-Markdown/MarkdownEditing/issues/659#issuecomment-952080964