search

SublimeText / Liquid

Shopify Liquid syntax for Sublime Text
https://packagecontrol.io/packages/Liquid
MIT License
18 stars 11 forks source link

Upgrade package for use with ST 4132+ #6

Closed deathaxe closed 2 years ago

deathaxe commented 2 years ago

This PR suggests a major upgrade to

  1. use latest features and base syntaxes of ST 4132.
  2. upgrade liquid language features
  3. fully support Jekyll syntax tags

Note: This PR requires a change to package_control_channel to limit this changes to ST4132+

Suggestion: Interested in moving the package to SublimeText organization?

deathaxe commented 2 years ago

@braver: Any thoughts?

braver commented 2 years ago

Sorry for not responding. Apparently my GitHub account kinda broke and was unable to send me notifications by e-mail, and effectively also unable to notify me about the problem. I was wondering why everything was so quiet 😆

Suggestion: Interested in moving the package to SublimeText organization?

Yes, definitely. Shall I just initiate the move? I haven't used this languages in ages and have no immediate interest in maintaining it all by myself.

braver commented 2 years ago

Alright, it's all yours. Hit me with a PR over at package_control_channel when you're ready.

deathaxe commented 2 years ago

Something seems wrong with your invitation link. Can't accept it.

Basically I am done. Just reorganized work into develop branch to keep master clean. Also created a st4126 branch on my end with a backported Markdown syntax, so we can provide all features for latest stable release as well.

As you are already a maintainer of SublimeText organization you should probably be able to move the package and rename it to "Liquid" afterwards. If an admin is required we might ask @FichteFoll to help us out - maybe at least with adding me as contributor/maintainer.

I'd update package control registry to use new location then.

FichteFoll commented 2 years ago

I have renamed the repository and configured permissions for @braver and @deathaxe.

braver commented 2 years ago

Something seems wrong with your invitation link. Can't accept it.

Yeah, that wasn't necessary. I couldn't find the transfer button and also assumed I couldn't do the transfer myself. But I found out I could and it has already been done. Sorry about the confusion, I'm rusty...

FichteFoll commented 2 years ago

As an aside, you may want to include a license.

braver commented 2 years ago

As an aside, you may want to include a license.

done

(by the way, none of the original work of the original repo the fork was based on remains here, I fully rewrote it years ago, but yeah ... I'm not particular about the license stuff 🤷🏻 )