search

SublimeText / NSIS

Sublime Text plugin for the Nullsoft Scriptable Install System
Apache License 2.0
40 stars 15 forks source link

Unicode support #10

Closed idleberg closed 11 years ago

idleberg commented 11 years ago

Modified build tools to support both ASCII and Unicode version of NSIS

idleberg commented 11 years ago

Let me add one bit of information about this. In my registry, i have currently keys for three different NSIS builds:

  1. HKLM...\NSIS
  2. HKLM....\NSIS Unicode
  3. HKLM...\NSIS ASCII

The 1st is for the official NSIS build, the 2nd for the official Unicode fork. I have know idea where the 3rd one is coming from, maybe the official NSIS build will use this in future for a better differentiation. I didn't want to add support for it until it's for certain. Anyway, that's the reason why I have constructed the if statement for the registry keys in the batch file like that (rather than using two "if %1==")

jeffory commented 11 years ago

Third one the Unicode NSIS's ANSI build I believe. It looks like it's just a version that supports older operating systems.

idleberg commented 10 years ago

I would like to think that support for the seperated Unicode fork can be removed again, now that the official NSIS versions has Unicode in-built. Yes, it's still in beta but typically regarded very stable. Afaik Jim Park, the creator of the Unicode fork, is involved in bringing Unicode to the official version, which probably explains why he hasn't updated his fork in two years.

So, I think it's save to remove unofficial Unicode support, I think that those looking at a Unicode version already use NSIS 3.0 beta. If you agree, I will proceed and submit a pull request.