search

SublimeText / NSIS

Sublime Text plugin for the Nullsoft Scriptable Install System
Apache License 2.0
40 stars 15 forks source link

Error loading syntax file - Sublime 3114 #32

Closed robotroll closed 8 years ago

robotroll commented 8 years ago

Hello,

with Sublime 3114 the syntax file for Nsis is causing following error: image

The corresponding lines in the file are:

- match: (\!include|\!insertmacro)\b
  captures:
  match: keyword.control.import.nsis

Regards, Robin

idleberg commented 8 years ago

@FichteFoll Any idea why convert_syntax.py would produce this?

@robotroll Will you submit a PR for your fix?

FichteFoll commented 8 years ago

@idleberg do you happen to have the source for that pattern?

idleberg commented 8 years ago

@FichteFoll The converter ran over the old NSIS.tmLanguage file, so that's the source of the pattern.

As for the pattern itself, I'm not sure about its origin. I think, I can say that I have broad overview of available syntax files for other editors, but don't recall ever seeing a distinction from other compiler commands. Since I never questioned the author's motive for this particular distinction, I never touched that pattern.

@robotroll I'm kind of surprised by the error message. When I could reproduce it, it stated NSIS.tmLanguage was causing the problem, not the new syntax file. Did you git clone the package or did you install/update with Package Control?

FichteFoll commented 8 years ago

Well, the same errorneous pattern is present in the file you linked (NSIS.tmLanguage), so I wouldn't fault the converter for this, except that it didn't panic.

robotroll commented 8 years ago

@idleberg I installed the package via Package Control. It always worked without a problem until I updated Sublime and restartet it. Since I was working on an .nsh file the error message popped up immediately.