search

SublimeText / NSIS

Sublime Text plugin for the Nullsoft Scriptable Install System
Apache License 2.0
40 stars 15 forks source link

Highlighting color changed with 2.0 release #36

Closed robotroll closed 7 years ago

robotroll commented 7 years ago

Hi,

the colors of the keywords changed with the new version. I expected the update to also highlight the variables in strings, but with the same color as before:

Old: image

New: image

I use the Afterglow theme in standard configuration. There was no change to the theme. Sublime version: Dev Channel, Build 3125

idleberg commented 7 years ago

Yes, as mentioned in the changelog, the scope names have been changed to be closer to the TextMate Naming Conventions. Since these changes are rather substantial/breaking, the new release is a major version.

I understand that this can be confusing at first, but I think this is a more straightforward approach that will also ensure better compatibility with theming standards such as base16. The old scopes often felt like they were not applied to follow the terminology of the actual language, but for the sake of forcing a different colors on different elements. Fine-tuned themes will make up for that, e.g. differentiate between variable.language and variable.other.

robotroll commented 7 years ago

Fair enough. I'll find another theme.

Good catch with the missing $PROGRAMFILES32 variables.

idleberg commented 7 years ago

Let me add that there will be a couple of more refinements in the near future. Also, I'm planning to release a new base16 template for Sublime Text, Atom, CodeMirror, highlight.js themes with NSIS development in mind. We use highlight.js on the upcoming new NSIS website, and the aim is to make highlighting more consistent across browsers and editors.