Sublime Settings: Some fixes and a proposal for your latest changes.

SublimeText / PackageDev

Tools to ease the creation of snippets, syntax definitions, etc. for Sublime Text.

MIT License

436 stars 83 forks source link

Sublime Settings: Some fixes and a proposal for your latest changes. #117

Closed deathaxe closed 7 years ago

deathaxe commented 7 years ago

This PR fixes a couple of issues introduced by changes made to the code of PR #113

FichteFoll commented 7 years ago

I'll take a look again over the weekend, probably.

deathaxe commented 7 years ago

Here are some suggestions to hopefully fix most of the issues. Please check, whether the back tick quoted completions - especially found lists - still work as expected. I'd suggest to use list items for completions rather than the list itself. This applies to list default values and lists found in comments.

FichteFoll commented 7 years ago

FYI, I started merging this a few days ago but am not through with it just yet. I'll cherry-pick any following commits, probably (which includes the latest).

FichteFoll commented 7 years ago

Thanks. Merged all but the last, which I cherry-picked.

I also more strictly pushed set usage and combined comment and default completions.