Sublime Settings: Fix default completion of empty default string

SublimeText / PackageDev

Tools to ease the creation of snippets, syntax definitions, etc. for Sublime Text.

MIT License

436 stars 83 forks source link

Sublime Settings: Fix default completion of empty default string #119

Closed deathaxe closed 7 years ago

deathaxe commented 7 years ago

If the default is an empty string it is not None but has nothing to offer.

This causes a value like "font_face" being completed with \t (default) str

FichteFoll commented 7 years ago

This will also trigger when the default is 0. Just add an explicit check for the empty string somewhere.

FichteFoll commented 7 years ago

Or False, even.

FichteFoll commented 7 years ago

Something went slightly wrong when merging this, which resulted in the last two comments actually not being merged. Since I already fixed the bug from the one commit, I just cherry-picked the other.

Anyway, this is merged.