SublimeText / PackageDev

Tools to ease the creation of snippets, syntax definitions, etc. for Sublime Text.
MIT License
436 stars 83 forks source link

Fix: sublime-color-scheme main key completions #194

Closed deathaxe closed 6 years ago

deathaxe commented 6 years ago

The main-keys of a sublime-color-scheme are currently being suggested within themselves.

This commit changes the selector to suggest main keys only within the top-level object where such keys are actually valid only.

FichteFoll commented 6 years ago

Uh, the - meta.mapping meta.mapping should already prevent this from happening. I'll have to take a closer look why it's not working as intended as it is now.

deathaxe commented 6 years ago

Hmm. Maybe - (meta.mapping meta.mapping) ?

deathaxe commented 6 years ago

@FichteFoll: How about main keys being suggested within themselves? I recently simplified my initial approach to fix that issue.

FichteFoll commented 6 years ago

Ah yeah, I forgot about this. I'll just include it in the next hotfix release.

FichteFoll commented 6 years ago

Made a small modification and went with the same approach as with themes.