search

SublimeText / PackageDev

Tools to ease the creation of snippets, syntax definitions, etc. for Sublime Text.
MIT License
436 stars 83 forks source link

Revert "add scope completion for punctuation.definition.numeric.base" #284

Closed deathaxe closed 4 years ago

deathaxe commented 4 years ago

This reverts commit d59b57e6e2bd6f7b1c8214a355dccf8377b38940.

The sublimehq team has decided to remove this from the core syntaxes before a ST4 stable release.

The only reason for that not to have happened yet is the pending discussion at https://github.com/sublimehq/Packages/pull/2229, which should provide a the answer about how to go on either by adding the proposed meta.scopes or just remove the punctuation scope.

Therefore we should not encourage anyone to use those scopes in the meanwhile by adding them to the completions here.

FichteFoll commented 4 years ago

I knew I had something on my mind while reviewing that (and why I haven't added the scopes myself yet), but I forgot what the current discussion was at.

By the way, have you looked at https://github.com/SublimeText/ScopeNamingGuidelines yet?

deathaxe commented 4 years ago

I've seen the repo, but I am busy at work atm, to take a serious look at it right now. Days are just too long atm.