search

SublimeText / PackageDev

Tools to ease the creation of snippets, syntax definitions, etc. for Sublime Text.
MIT License
436 stars 83 forks source link

[ST4] Add support for various `block_caret_` global settings in color schemes. #317

Closed UltraInstinct05 closed 3 years ago

UltraInstinct05 commented 3 years ago

This PR

  1. Adds appropriate completions for various block_caret_ global settings introduced in 4086.
  2. Adds these in the syntax file for appropriate highlighting.

Here is a brief summary of them.

  1. block_caret_corner_style: Controls the corner style of block carets. Valid values are cut, round & square.
  2. block_caret_border: Controls the color of the block caret's border.
  3. block_caret_underline: Controls the color of the block caret inside a selection. The color of the block caret inside a selection will fallback to the color of the caret global if block_caret_underline is not defined.
  4. block_caret_corner_radius: Controls the corner radius of block caret. This value lies in the range [0, 10]
UltraInstinct05 commented 3 years ago

Made a commit that adds block_caret_corner_radius and also fixed an issue where block_caret itself wasn't being highlighted.

UltraInstinct05 commented 3 years ago

I had previously placed all the block_caret_ settings in the first match of globals-mapping-key context, hence block_caret_corner_radius and block_caret_corner_style wrongly supported color variables in them. I made a commit that rectifies this.

FichteFoll commented 3 years ago

Thanks!