Add Old Buddy color scheme optimized for PowerShell code

[guillermooo]

This PR also sets the Old Buddy color scheme as the default color scheme for PowerShell files. Users can still override this. Not sure whether it's a good idea, though it'd sure raise the color scheme's profile :)

[vors]

I would not change default color schema. People are sensitive about such things.

[guillermooo]

Agreed. I will remove the setting.

[vors]

In general, feels like it uses too much bold. Text looks heavier, then it should, imo. But I'm a noobe in color schema. @bcrotty ?

[vors]

BTW, I think it's awesome anyway. Feel free to merge.

[bcrotty]

@vors I think it would be helpful to include this, but it might be easier to find/understand if we name it something like "PowerShell ISE". There are still quite a few differences from ISE though. I'd want to keep tweaking these, but some might be syntax differences as well.

[guillermooo]

I've fixed a few things. I think this ready for a first version.

Re. name. I don't know. Maybe using 'PowerShell ISE' is a problem. Also, as you say, it isn't exactly the same scheme. 'Old Buddy' alludes to PSISE, but it's certainly obscure. I'm not sure we should worry too much about the name, though. Maybe if we advertise as it as 'based on PowerShell ISE colors' in the readme, changelog, etc. and include a screenshot it'll be enough.

I'm open to changing the name; I just don't know if 'PowerShell ISE' is the right one due to potential legal concerns or misinformation.

[vors]

I asked our PM for powershell_ise and he recommend use something like "PowerShell ISE-like", but not "PowerShell ISE" to avoid confusing and questions from LCA.

[guillermooo]

Thanks for inquiring, @vors.

"PowerShell ISE-like" won't be too catchy... How about "PS Standard"?

PS Basic PS Original PS Light ...

[vors]

Currently in preferences schema is under Color Schemas -> PowerShell -> Old Buddy -> Old Buddy light

Subfolder Old Buddy is unnecessary. Also, because PowerShell already showed up in this path, we can use "ISE inspired" as a name (dropping PowerShell word).

[vors]

Wait, it's actually even longer:

[guillermooo]

Hm. I think you have a level too many. The package's top-level dir should be named PowerShell, BTW. Otherwise I don't think the Python code will work.

I'll move the theme out of the Support folder.

[vors]

Yeah, it's my dev installation and name is different historically.

[guillermooo]

Still not happy with the name, though. If you look at the default names for color schemes, they are all pretty fancy. 'ISE Inspired' looks too dry by comparison.

[guillermooo]

ISE New or ISE Modern could work for me.

Also ISE Nostalgia, but that's perhaps too fancy?

[vors]

I like 'ISE Nostalgia'

[vors]

Preview for references

[guillermooo]

@vors I'll try to change the color scheme's name as discussed and then merge this.

[guillermooo]

Closing this one and reopening new PR.