Nested properties don't highlight correctly

[yb53]

Hi,

Firsdt of all, thank you for your hard work. Here are just 2 trivial regressions from the previous version, the first one about property nesting and the second about function parameters.

Except for "size", all other nested parameters (weight, style, radius, appearance, etc) are not recognized and end up constituing a funny color pattern.

As for the function parameter, the "$foo" is not identified and not highlighted.

Of course it is the same for this kind of declarations: =background-size($property) 　-webkit-background-size: $property 　-moz-background-size: $property 　 background-size: $property

Thank you again for your work, and if you ever have a sparetime with nothing to do, then perhaps~

[braver]

@yb53 Hi, thanks for the feedback!

Property nesting has been broken to fix something else. I need to revise how the syntax decides if something is a selector or a property to fix this correctly. Sadly it's not a trivial problem.

As for parameters, Monokai doesn't highlight variables: they're just white. So this is correct:

However, ideally $foo would be orange here, or variable.parameter instead of variable.other.

Anyway, hope you enjoy the improvements the new syntax brings. These and other improvements are sure to follow.

[braver]

for the parameters, please track #17

[cem90]

I have a similar issue with mixins and comments within the sass-highlighting. Some mixins are highlighted correctly, some are not.

Comments are not even possible with the shortcut inside Sublime Text 3.

Am I missing sth. or is that a real issue?

For example:

[braver]

I think I'm missing some key syntax features here for Sass specifically, like the =<mixin> and +<include mixin>: http://sass-lang.com/documentation/file.INDENTED_SYNTAX.html#Mixin_Directives

That should be an easy fix, I'll let you know what I come up with

[cem90]

Okay cool. Thx a lot!

Specifically for Sass sintax, there are some more highlighting issues... but that would be too much to show here.

[braver]

@raedlime 2.0.4 should become available soon with fixes:

• commenting using the key binding should work again
• + and = syntax for mixins should be supported now. I probably need to add more test cases to cover everything, but should be a lot better than before :)

[cem90]

Okay, nice. Waiting for the upgrade then.

[cem90]

Got the upgrade now. Comments are possible now, but the thing with the mixins highlighting still doesn't work properly.

Example v.2:

Example: v.1:

The highlighting for using the mixins works fine, as far as I can see.

[braver]

@raedlime this should be fixed in 2.0.5 already (although the @content keyword is missing):

[cem90]

mh, okay. Idk what's wrong with my sass then. But it looks like, either the @content keyword breaks every thing following or the variable.

[dr-dimitru]

@braver

Anyway, hope you enjoy the improvements the new syntax brings. These and other improvements are sure to follow.

Can't enjoy it, all broken in deeply nested trees 😞

But, I love your fork of the lib, and don't wanna go to original package. Any options? What last stable version?

[braver]

@dr-dimitru can you give me a test file so I can see what’s wrong?

[dr-dimitru]

@braver sure, actually I found exact line was causing it, right after multiple :not(/*...*/):

input:not([type="radio"]):not([type="checkbox"]):not([type="range"]):not([type="image"]), select, textarea
  display: block
  transition-property: background-color, border-color
  transition-duration: 256ms
  transition-timing-function: ease
  background-color: $white
  border: 1px solid lighten($black, 75%)
  padding: 6px 10px
  border-radius: 2px
  width: 100%
  min-width: 80px
  font-weight: 400

And commenting with double-slash //

You should be able to reproduce on your end, details:

• MacOS X 10.13.6
• Sublime 3.1.1
• node-sass@4.9.4
• (this package) sublime sass at the latest version

[michaelblyons]

It looks like a single :not(span) is enough to trigger the problem. The meta.function-call meta.group stacks never pop.

:not(span)
  display: block

[braver]

Thanks guys, that should be fixable.

[braver]

The :not() issue fixed in 89dab3a

[michaelblyons]

89dab3a fixed OP's case and :not(.class). Is :not(tag) valid Sass? Because that still doesn't pop.

(Maintenance of a popular package seems to be a huge chore. 😉)

[braver]

Maintenance of a popular package seems to be a huge chore

Yeah, some maintainers tend to go with not actually doing the maintenance 😉 This is all good though, lot's of use cases I don't come across myself a lot. Just some things to get right and if I set it up correctly I think it'll be peanuts later.

[dr-dimitru]

@michaelblyons @braver :not() can be used with any selector class, id, element name

[braver]

@dr-dimitru @michaelblyons thanks guys, caught those as well now.

[dr-dimitru]

@braver thanks for quick update, testing now. Everything seems to be good, but still feels like something off, like color schema changed, or ... idk...

I'll report if something will popup later.

[cem90]

Most of the highlighting works pretty awesome. Thanks for the work on the issues found last week (y) But, I found some little issues this morning. I hope, I don't annoy you... but I think, we all want this to work properly :-)

Here are the little issues I'm talking about:

When I use "background-image" on it's own, it works perfectly:

[braver]

Yeah, most work last week was to iron out the other issues that were found. Property-nesting still doesn't work at all really, which is what you're seeing here.

[braver]

Should be fixed in 2.2!