SublimeText / Sass

Sass and SCSS syntax for Sublime Text
https://packagecontrol.io/packages/Sass
MIT License
50 stars 8 forks source link

SCSS variable highlighting stopped working #22

Closed dylanfisher closed 5 years ago

dylanfisher commented 5 years ago

Using v2.0.7

Highlighting just disappeared for SCSS variables. Pretty sure this was working prior to v2.0.7.

screen shot 2018-10-31 at 4 06 24 pm
braver commented 5 years ago

That might just be what variables look like in your color scheme. What do variables look like in say JavaScript?

dr-dimitru commented 5 years ago

@braver same, here, again: screen shot 2018-11-03 at 1 44 50 am where:

dr-dimitru commented 5 years ago

@braver here is how js code is highlighted screen shot 2018-11-03 at 12 14 18 pm

braver commented 5 years ago

Your JS example clearly shows that as well:

The old version of Sass got it wrong, it’s probably the only syntax out there that scopes things like it does.

braver commented 5 years ago

@braver same, here, again: screen shot 2018-11-03 at 1 44 50 am where:

  • @media should be red
  • all variables orange and italic
  • backdrop-filter should not be red

You may be right about the @media and the backdrop-filter though.

dr-dimitru commented 5 years ago

Not sure if this one deserves separate issue:

.sidebar
  background: none
  @media(max-width: $break-parent)
    will-change: transform, scroll-position
.sidebar
  background: none
  will-change: transform, scroll-position

Where transform and scroll-position has two different colors screen shot 2018-11-14 at 7 54 32 pm

braver commented 5 years ago

I'm closing this. The original issue as far as there was any has been resolved. backdrop-filter isn't a standardized property and therefore not recognized. In any case that's something completely seperate from the original issue. @dr-dimitru this is something else, unrelated to the other issues raised here. I don't have a fix for that yet, but have a test in place and will look at a solution soon.