SCSS parameters and boolean type coloring issue

SublimeText / Sass

Sass and SCSS syntax for Sublime Text

https://packagecontrol.io/packages/Sass

MIT License

50 stars 8 forks source link

SCSS parameters and boolean type coloring issue #23

Closed suwaishing closed 5 years ago

suwaishing commented 5 years ago

First of all, I highly appreciate your work here with quickly respond. Secondly, there're still problems with the parameters and value true false in SCSS, as below

and this is SCSS parameters

Environment

Sublime text version 3.1.1, build 3176
Sass v2.0.7 (updated)

More info

The parameter was orange and True/False value was not yellow before. So I think it's nothing to do with color scheme.
And it's look normal in Javascript:

_Originally posted by @suwaishing in https://github.com/braver/SublimeSass/issue_comments#issuecomment-434901376_

braver commented 5 years ago

Just to make sure I understand you correctly:

parameters in a function definition should be orange in Monokai, so that's correct
boolean values aren't recognized and are now incorrectly colored yellow, so that's an actual bug

Migshu commented 5 years ago

Variables ceased to be painted in orange color. In addition, the compiler (Koala) does not see them, gives an error. What to do? 2018-11-02 19 42 12 2018-11-02_19-45-31 2018-11-02_19-46-50

braver commented 5 years ago

Variables ceased to be painted in orange color

This is probably as expected. See #22. The old version of this package used incorrect scopes for variables.

I don't know what the Koala app is or what problem you're facing there. I doubt this syntax has anything to do with that though.

Migshu commented 5 years ago

The old version of this package used incorrect scopes for variables.

Thanks for your prompt reply!

braver commented 5 years ago

Closed: variables shouldn't be orange, true/false constants have been added in 2.2.1