search

SublimeText / Sass

Sass and SCSS syntax for Sublime Text
https://packagecontrol.io/packages/Sass
MIT License
51 stars 8 forks source link

Grid values #49

Closed sandrojohanides closed 5 years ago

sandrojohanides commented 5 years ago

There are various little bugs in grid values (keywords, numbers, etc.). The syntax sections of these can be used to create tests:

https://developer.mozilla.org/en-US/docs/Web/CSS/grid https://developer.mozilla.org/en-US/docs/Web/CSS/grid-template-columns https://developer.mozilla.org/en-US/docs/Web/CSS/grid-auto-columns

Let me know if you want me to point out the specifics.

braver commented 5 years ago

Thanks! The MDN docs are super valuable, I think I'll manage with those links.

braver commented 5 years ago

@sandrojohanides I pushed some fixes for grid syntax. Anything in particular that's still broken or missing for you?

sandrojohanides commented 5 years ago

Look beautiful, only bug I see is with the auto-fit and auto-fill keywords, which should be red.

screen shot 2018-12-07 at 17 57 17

From here: https://developer.mozilla.org/en-US/docs/Web/CSS/grid-template-columns

braver commented 5 years ago

Just like in the CSS syntax, they're labelled as support.keyword.repetitions.css. I don't know why exactly. I value the consistency with the CSS, so if you want this changed better open an issue there.

I'm going to close this issue, if you find anything else, please report! Thanks so much for cooperating this last week! 🏅