SublimeText / Sass

Sass and SCSS syntax for Sublime Text
https://packagecontrol.io/packages/Sass
MIT License
51 stars 8 forks source link

Goto definitions (2.3.8) #57

Closed KubaJastrz closed 5 years ago

KubaJastrz commented 5 years ago

I'm not sure if I'm missing something, but go to symbol functionality stopped working a while ago.

Here's how it looks in the v2.3.8: 2019-01-15_20-40-57

I tracked down the #32 issue and e5d82f41b7f46cea41de53448777f433cf861cb6 that was supposedly fixing it. But I believe that the core of the problem lays in b048ae6707dccf8b80dabb7ae955de59530e474c, where Symbol definitions where removed completely.

KubaJastrz commented 5 years ago

I've made simple test case similiar to one above:

$div: div;

.one {
    &__two { color: #000; }
}

.three { color: #000; }

#four { color: #000; }

#{$div} { color: #000; }

.#{$div} { color: #000; }

##{$div} { color: #000; }

span { color: #000; }

Here is .tmPreferences file that targets all of them (except #{$div} - maybe an edge case, but works in REPL):

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
  <dict>
    <key>name</key>
    <string>Goto Symbol</string>
    <key>scope</key>
    <string>meta.selector.css (entity.other.attribute-name, entity.other.attribute-name.id, entity.other.attribute-name.class)</string>
    <key>settings</key>
    <dict>
      <key>showInSymbolList</key>
      <integer>1</integer>
    </dict>
  </dict>
</plist>

Preview: 2019-01-15_21-03-04

braver commented 5 years ago

I think there is something in your setup that's causing this. Can you list your installed packages, settings, etc.?

This is what is should look like on a basic install:

screen shot 2019-01-15 at 22 12 44
KubaJastrz commented 5 years ago

I'm gonna double check my packages folder. But just to confirm - this package doesn't contain any custom symbol rules, right?

Edit: I haven't found anything that could override that behavior :/ Edit 2: I'll do clean install tomorrow and check there if it's working correctly

travm commented 5 years ago

I'm experiencing this issue as well. Tried removing other packages, but nothing seemed to fix it. Not much else has been customized outside of that.

braver commented 5 years ago

I can’t help unless

Can you list your installed packages, settings, etc.?

KubaJastrz commented 5 years ago

My packages: A File Icon, ChangeQuotes, DocBlockr, Emmet, GitGutter, GitSavvy, JsPrettier, Package Control, PackageResourceViewer, Sass, ScopeAlways, SideBarEnhancements, SublimeLinter, SublimeLinter-contrib-sass-lint, SublimeLinter-tslint, Terminal, TypeScript

There are not settings that could affect subilme's behavior, except *.tmPreferences files with <key>showInSymbolList</key>. I have scanned most of the packages already and haven't found any conflicts with this package.

KubaJastrz commented 5 years ago

CSS package has these:

braver commented 5 years ago

There are not settings that could affect subilme's behavior

You’d be surprised. Again, please share your settings.

travm commented 5 years ago

The only package that is installed is this one. All default settings.

braver commented 5 years ago

Thanks, I think I found the culprit now.