SublimeText / Sass

Sass and SCSS syntax for Sublime Text
https://packagecontrol.io/packages/Sass
MIT License
50 stars 8 forks source link

No support for custom pseudo classes #72

Closed niksy closed 5 months ago

niksy commented 3 years ago

Following code doesn’t add possibility to style custom pseudo class (upstream CSS syntax allows that).

.example:enter {
    color: red;
}
braver commented 3 years ago

Fair point. This has a specific reason. It's part of the pattern matching that helps decide if what you're writing is a selector or a property. Because Sass can be nested (and CSS can't), this is needed to decide if color:red is a property or a selector with a pseudo class. I want to eventually revisit how this is handled. Sublime Text 4 brings a new way to write syntaxes with actual branching etc. It might be possible to keep the highlighting ambiguous longer (ie. while you're typing) and resolve the selector/property decision later. It's tricky though, because that also affects completions. But that would also make it possible to resolve interpolation in property-names (#54). So, yeah, this is an issue, but it's a concession to make highlighting possible in unfinished blocks of codes.

niksy commented 3 years ago

Should we close this or wait for ST4 changes?

braver commented 3 years ago

Well I’ll probably remember even if we close this, but it’s still a valid issue. So let’s keep it open. ST4 still feels like a moving target, so I want to wait for a little while still.

braver commented 2 years ago

A 3.0 beta release is out now, check the readme on how to get the early builds to take advantage of the improvements and help out improving the package before we ship it to the world.

braver commented 5 months ago

closed via #96