search

SublimeText / Sass

Sass and SCSS syntax for Sublime Text
https://packagecontrol.io/packages/Sass
MIT License
50 stars 8 forks source link

CSS logical properties syntax highlghting #85

Closed dwhenson closed 2 years ago

dwhenson commented 3 years ago

Hi, just to mention that some of the newer css properties don't seem to be recognised by the Sass package. I'm thinking logical properties and some of the recent grid properties (e.g. place-items.) I've attached an image showing the issue. If you need more details just let me know. Thanks

Screenshot 2021-08-12 at 19 38 05
braver commented 3 years ago

The first question is always: are they supported by the default CSS package?

dwhenson commented 3 years ago

Yes, if I switch the syntax to css it seems fine. See attached screenshot. (I just copied and pasted the text above in a CSS file)

Screenshot 2021-08-13 at 15 26 46
braver commented 3 years ago

Thanks for checking that. I’m busy “re-basing” this package on the default CSS syntax, which is quite a bit of a project, so this should resolve itself when that gets done.

dwhenson commented 3 years ago

Brilliant - thanks so much. Appreciate the hard work!!

dwhenson commented 2 years ago

Hey just wondered how work on this one was going. Do you think it will be manageable to fix?

braver commented 2 years ago

The work is ongoing, but getting there 🤞🏻

dwhenson commented 2 years ago

Awesome - great to hear! Thanks for all the effort!

braver commented 2 years ago

FYI, the match-css-rewrite branch is usable. I need to go through some tests but they are mostly failing because a lot of scope names were changed in the default CSS package. And I need to have a closer look at completions, but they seem to at least sort-of-work.

dwhenson commented 2 years ago

Awesome!! Thanks so much looking forward to giving this a try!

dwhenson commented 2 years ago

Hey. Just checking in how the work is going? I'm sure it's a lot but super excited to try this out!

braver commented 2 years ago

I’ve been use-testing it for a while now me and it seems fine I guess. Haven’t run into anything big really. I want to have closer look at the completions before I tag a release though.

Op 27 nov. 2021 om 08:37 heeft Dave Henson @.***> het volgende geschreven:

 Hey. Just checking in how the work is going? I'm sure it's a lot but super excited to try this out!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

dwhenson commented 2 years ago

Hello me again.... just checking in to see if you are planning a release anytime? Is there a way I can try and then let you know if I encounter any issues, or help in any other way?

braver commented 2 years ago

A 3.0 beta release is out now, check the readme on how to get the early builds to take advantage of the improvements and help out improving the package before we ship it to the world.

dwhenson commented 2 years ago

Looks beautiful! Great stuff. I'll keep an eye out and let you know if I see any issues...Lovely!!