search

SublimeText / Spacegray

A Hyperminimal UI Theme for Sublime Text
https://sublimetext.github.io/Spacegray/
MIT License
7.19k stars 431 forks source link

Add icon for folders that Sublime thinks are links #208

Closed appsforartists closed 6 years ago

appsforartists commented 6 years ago

Some folders appear as if they have no contents - both open and closed, no files are listed beneath them. Adding "Theme - Spacegray" to my ignored_packages fixes this. Sublime r3156 on macOS 10.12.6.

marcofugaro commented 6 years ago

Can't reproduce the bug, do you have an example repo where it happens or some screenshots?

appsforartists commented 6 years ago

I think this was a coincidence - the root cause appears to be that some of my tools were making symlinks from node_modules to other packages in my project. n comes before p lexicographically, so Sublime was treating node_modules as canonical and packages as dupes.

Spacegrey was masking the issue by not showing the link icon for the elided folders, but I think it was just coincidence that disabling it brought the contents back when I opened this issue.

marcofugaro commented 6 years ago

There already is an icon for symlinks, it's a folder in an arrow in it, here is the relative code: https://github.com/kkga/spacegray/blob/9cddef9b5949100c84e87bc40e41885f4156b4de/Spacegray.sublime-theme#L699-L702

Tested it and it works fine, otherwise I don't know which files you are referring to, closing.