search

SublimeText / WordHighlight

Highlight all copies of the currently selected word.
MIT License
179 stars 24 forks source link

Ocurrences fix #18

Closed titoBouzout closed 12 years ago

titoBouzout commented 12 years ago

When multiples words are highlighted the status bar displays a misleading message.

For example... buffer contains

la
la
la
la

boo
boo
boo

When you select "la" and then with Ctrl key "boo" status bar should display: "4 occurrences of "la", 3 occurrences of "boo" instead of '7 occurrences of "boo" '

adzenith commented 12 years ago

This is a good catch, by the way. The current behaviour is obviously wrong. Thanks!

liamcain commented 12 years ago

The current behaviour is obviously wrong.

Thanks for kicking me while I'm down...

But anyway, sorry about that, I don't use multiple selections very often so in my plugins I forget to support them.

adzenith commented 12 years ago

Well, one of the reasons I called it a good catch is because I didn't notice it was broken either. The wrongness was something that became obvious once someone submitted a pull request to fix it :)

titoBouzout commented 12 years ago

This just an exception, is not wrong. :)

adzenith you may want to try a different approach, I'm not sure right now.

Regards

adzenith commented 12 years ago

BoundInCode, I was reading this conversation again and it's clear that I said something that sounded mean and then gave a fake sort of apology. I just wanted to apologize for real. I'm sorry.

adzenith commented 12 years ago

Tito, I'm on holiday for the next three weeks. Should I just pull this, or would you rather we try a different method?

liamcain commented 12 years ago

haha adzenith. Don't worry about :) I was just playing around. I don't really mind.

But you should probably pull this. Have a nice vacation.

adzenith commented 12 years ago

Done and done.