search

SublimeText / WordHighlight

Highlight all copies of the currently selected word.
MIT License
179 stars 24 forks source link

Sublime 3 compatibility #38

Closed johnburnett closed 11 years ago

johnburnett commented 11 years ago

A quick pass at Sublime 3 compatibility, requires build 3009+ (for plugin_loaded callback support)

adzenith commented 11 years ago

Thanks for the pull request! I'll take a gander. Also, I hate to be like this, but could we leave it as tabs?

johnburnett commented 11 years ago

adzenith - you're welcome! And just to give context to this pull request: I went down the path of doing a larger overhaul of this plugin to make it a bit "cleaner"... I still have it in a branch locally, but in the end I went back to doing a minimum set of changes needed to get it working in Sublime 3. The comments brought up elsewhere are valid, but were outside of the scope of the "get it working now and touch as little as possible" patch I was hoping to get accepted :).

On the tabs vs spaces thing.... I was just following the Python style guide of preferring spaces. I think there were already mixed tabs/spaces in the file, so this was just making it consistent, with an eye towards Python style.

johnburnett commented 11 years ago

...back to tabs!

titoBouzout commented 11 years ago

Since this request may have something to correct under ST3 only, what do you think about merging this first step? @adzenith

adzenith commented 11 years ago

Hey! Sorry for the delay. I squashed the first three commits together and then merged. Thanks for the contribution!

adzenith commented 11 years ago

Also, John, if you still have that larger overhaul lying around I'd be interested in seeing it!

johnburnett commented 11 years ago

Great! Though - you may want to grab the fourth bit. There was a missing global declaration for the settings_base variable. Ugly, but required to work :/

On Tue, Feb 5, 2013 at 8:42 AM, Nikolaus Wittenstein < notifications@github.com> wrote:

Hey! Sorry for the delay. I squashed the first three commits together and then merged. Thanks for the contribution!

— Reply to this email directly or view it on GitHubhttps://github.com/SublimeText/WordHighlight/pull/38#issuecomment-13138601.

adzenith commented 11 years ago

Yeah, sorry if that was unclear - I merged all four, but I squashed the first three together. Thanks!