search

SublimeText / sublime_lib

Utility library for frequently used functionality in Sublime Text and convenience functions or classes
https://sublimetext.github.io/sublime_lib
MIT License
52 stars 4 forks source link

Change typing stub to make pyright happy. #172

Closed Thom1729 closed 3 years ago

Thom1729 commented 3 years ago

Fix #171.

FichteFoll commented 3 years ago

Do you want to make a hotfix release for this?

rchl commented 3 years ago

If you would want to ignore the reportWildcardImportFromLibrary warning you can add a configuration file in the root:

diff --git a/pyrightconfig.json b/pyrightconfig.json
new file mode 100644
index 0000000..d8bd1c1
--- /dev/null
+++ b/pyrightconfig.json
@@ -0,0 +1,4 @@
+{
+    "pythonVersion": "3.8",
+    "reportWildcardImportFromLibrary": "none"
+}

The pythonVersion is not relevant to the warning but would be good to have it explicit so that it guards against using "too new" features.

rchl commented 3 years ago

Can we get this out?

FichteFoll commented 3 years ago

@Thom1729 can you?

FichteFoll commented 2 years ago

Do we not need a (hotfix) relase for it?

Thom1729 commented 2 years ago

If we can merge #166, we can release 1.6 and there's probably no need for a hotfix. If not, I can release a hotfix tonight or tomorrow.

FichteFoll commented 2 years ago

SGTM.