SubmarinerApp / Submariner

A Subsonic client for macOS
https://submarinerapp.com
BSD 3-Clause "New" or "Revised" License
123 stars 3 forks source link

When using Navidrome, clicking star rating returns unsupported URL #120

Closed jboxman closed 1 month ago

jboxman commented 1 year ago

I'm able to connect successfully and the entire library loads. When trying to rate a track, however, a window pops up that says "unsupported URL". The rating doesn't seem to show up in the Navidrome UI, so I don't think it gets saved. It seems to persist locally, however.

NattyNarwhal commented 1 year ago

Navidrome, at least the version I have installed, doesn't support ratings; only starring (which isn't supported yet, see GH-113). As you noted though, it should persist locally in the database even it it can't send it out to the server.

NattyNarwhal commented 1 year ago

Ideally, we should hide things if the other end doesn't support them, but this is a bit hard considering the Subsonic API has no real way to declare a supported featureset. All we can really rely on is the API endpoint returning unsupported feature when actually used.

NattyNarwhal commented 1 month ago

closing because navidrome does have star ratings, and opensubsonic promises to make it possible to determine supported features ahead of time. we're not using it yet, but we probably will in the future