SubmarinerApp / Submariner

A Subsonic client for macOS
https://submarinerapp.com
BSD 3-Clause "New" or "Revised" License
123 stars 3 forks source link

View conversion to SwiftUI #123

Open NattyNarwhal opened 1 year ago

NattyNarwhal commented 1 year ago

Downloads view has been converted and it seems to work pretty well.

Concerns would be:

NattyNarwhal commented 10 months ago

I have a prototype of Database in a SwiftUI test project with:

But:

NattyNarwhal commented 9 months ago

SwiftUI has a very annoying issue for the tracklist (and probably playlist) case, where you can't really have multiple of the same tracks in whatever collection the Table/List represents, because the selection is based by a Set<SBTrack>, not by an index. It'd need a data model change, or regress to the pre-index change. Might have to play with .enumerated() sometime...

NattyNarwhal commented 9 months ago

Another issue is that Table requires macOS 12. We still support 11, but I don't know if it'd be worth dropping it. App Store users look to be mostly on 12 or 13.