SubmarinerApp / Submariner

A Subsonic client for macOS
https://submarinerapp.com
BSD 3-Clause "New" or "Revised" License
133 stars 4 forks source link

Add Submariner.app to homebrew-cask #127

Closed cmarhoover closed 1 year ago

cmarhoover commented 1 year ago

I attempted to add the latest version of Submariner to the homebrew-cask repo, but the commit was rejected because active development on Submariner is occurring on this fork without pushing changes upstream.

Closed pull request here: https://github.com/Homebrew/homebrew-cask/pull/146138#issuecomment-1528443121

Relevant discussion on creating casks from forks here: https://github.com/Homebrew/homebrew-cask/issues/142510

NattyNarwhal commented 1 year ago

There was what I read as implicit approval in upstream, but I don't know if that helps you.

cmarhoover commented 1 year ago

Thanks! That thread was sufficient, and my pull request was merged here: https://github.com/Homebrew/homebrew-cask/pull/146454. Submariner.app v2.2 is now installable through homebrew, and is listed in the repo here: https://formulae.brew.sh/cask/submariner