search

SubmarinerApp / Submariner

A Subsonic client for macOS
https://submarinerapp.com
BSD 3-Clause "New" or "Revised" License
140 stars 4 forks source link

Server reporting "Unvalid license" even though it's connected successfully #160

Closed GetOutOfMyBakery closed 1 year ago

GetOutOfMyBakery commented 1 year ago

What

Last follow on from this comment. When I've created a server connection on 2.4, I'm now seeing Unvalid License in when I go to Configure Server on a successfully connected server. My previous server connection (from 2.3.1 did not have this message).

I noticed this on my other (work) Mac, so came to check it on my own Mac which had been successfully connected on a previous build (2.3.1). I reproduced the issue when connecting to the same server on 2.4. Both times the indicator was green.

I also had a little dig through the code and it looked like it's associated to the presence/absence of an email address for the user account (I might be wrong on this), so I gave my Navidrome user a temporary email address, and re-connected. This didn't seem to resolve the issue though.

Steps to reproduce

  1. Connect to a new valid server on Submariner 2.4
  2. Click Configure Server, and see if you have a successful connection

Screenshots

image

Versions

NattyNarwhal commented 1 year ago

It's because Navidrome doesn't return any license info in getLicense:

<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.16.1" type="navidrome" serverVersion="0.40.0-FREEBSD (8799358)"><license valid="true"></license></subsonic-response>

...and the default license

Screenshot 2023-08-21 at 10 53 02 PM

It's purely cosmetic, the ok in there means that the valid license bit is set, making the light there green. Submariner and Navidrome don't actually do anything with license information, but Subsonic does care.