Use tag instead of directory based metadata

SubmarinerApp / Submariner

A Subsonic client for macOS

https://submarinerapp.com

BSD 3-Clause "New" or "Revised" License

122 stars 3 forks source link

Use tag instead of directory based metadata #177

Closed NattyNarwhal closed 7 months ago

NattyNarwhal commented 7 months ago

Avoids the ugly contorting of the data model from arbitrary directory structure to artist-album-track. This should make the API requests actually match the original data model.

I have only tested with Navidrome. Since Navidrome uses identical IDs for the fake hierarchy and the tags, the transition is seamless.
I haven't tested Subsonic. Since it uses different IDs for directories vs. tags, it's likely this won't be so smooth. Recreate your server. (Could this be handled better?)
Nor have I tested other implementations.
Podcasts may be busted. The podcast functionality is really bitrotted and not well tested regardless.
We could do real directory hierarchies (GH-173) correctly, with a data model actually modelling... directories.

Fixes GH-73

NattyNarwhal commented 7 months ago

I'd like your help testing this pull request. Let me know if it works for your server (or not), and if you run into any issues. I've only tested this against Navidrome so far; I'd like to know how it works for the other questions raised in the description for this PR.

Backup your database before doing anything. At minimum, the Submariner Library.sqlite files, and the whole Submariner directory if you want to play it safe. This version includes a database schema upgrade, so you may not be able to revert back to a previous version until you restore the database (or reset it).

Although it identifies as "2.4.2", it includes all the changes made since then intended for 2.5, as well the changes in this PR. If you have issues or questions regarding those unrelated changes, file a separate issue.

(This comment will be updated as needed)

Download here 2e7318e

~~Download here~~ Older, 5591c09

~~Download here~~ Older, fc64db5

NattyNarwhal commented 7 months ago

Build coming soon with the changes pushed since the release, but I've been testing Subsonic and trying to handle migration correctly:

Podcast support will probably be more broken until correct raw directory support is done, since podcast APIs hard rely on parent. (That'll involve at least schema changes, plus UI for it.) That, or maybe just call getSong on the streamID if it works for a podcast episode's file? Maybe podcast support can be removed, unless someone's using it?
Artist and albums in the conversion are still a bit wonky. The first reordering of the library can be confusing, but switching from the server and back can fix that. Disassociated albums might appear and get code 70'd (with a message box), but sorts itself out for that artist after that.

NattyNarwhal commented 7 months ago

Podcast support was really broken before, but now it's... limping, with some UX confusion going on. It might be fixable, but it'll have to block on this branch.

NattyNarwhal commented 7 months ago

I think I'll just go ahead with this and consider this a change that might merit a 3.0.