SubmarinerApp / Submariner

A Subsonic client for macOS
https://submarinerapp.com
BSD 3-Clause "New" or "Revised" License
140 stars 4 forks source link

Disc support in the track list #188

Closed skyline75489 closed 10 months ago

skyline75489 commented 10 months ago

Describe the bug

Tracks from different discs are incorrectly organized in the track list.

To Reproduce

截屏2024-01-22 15 26 47

Note how the track with No.1 is grouped together. They're from different discs

Expected behavior

截屏2024-01-22 15 27 11

Screenshots If applicable, add screenshots to help explain your problem.

Versions:

Additional context Add any other context about the problem here.

NattyNarwhal commented 10 months ago

Odd, the default sort order should be disc-then-track; there's a method assigned to the table's delegate that should also force that sort order if you click the disc number column. If that doesn't work, I'd wondered why. I'm also using Navidrome, so it should understand disc numbers coming back from responses. too.

FWIW, there is the "use more violence approach" - the table sort descriptors seem to be saved in default keys prefixed with NSTableView Sort Ordering v2.

skyline75489 commented 10 months ago

Yeah...clicking the dis number column fixes the order, and the wrong order is gone forever.

NattyNarwhal commented 10 months ago

Good to know that fixes it, though it's a little strange that it got that way in the first place. Do you remember anything that happened that might have changed the sort order?

skyline75489 commented 10 months ago

Nothing really. I just launch the app the first thing I see is the wrong order in the screenshot.

NattyNarwhal commented 10 months ago

Strange. I'll close this since it's been fixed. If you can reproduce it, please reopen it and let me know.

blindmanonacid commented 1 month ago

Hi, just want to mention that on a fresh install the tracks are still not organized by disc number. After searching the issue I came upon this report and clicking the number column have solved it.