search

SubmarinerApp / Submariner

A Subsonic client for macOS
https://submarinerapp.com
BSD 3-Clause "New" or "Revised" License
123 stars 3 forks source link

Handle album art that's non-square #37

Closed NattyNarwhal closed 4 months ago

NattyNarwhal commented 2 years ago

Maybe just do some filter step where we insert the dominant background colour or something?

Screen Shot 2022-06-12 at 4 40 19 PM Screen Shot 2022-06-12 at 4 40 42 PM
NattyNarwhal commented 1 year ago

if we want to select a background colour from the image, a library like https://github.com/dagronf/DominantColor may be useful

NattyNarwhal commented 4 months ago

FWIW, I think due to the way the inspector view handles layouts now (SwiftUI dynamically reflowing based on image size), isn't as needed. Apple Music also doesn't do any special casing for non-square artwork in the in-app and in NPIC views, as shown below:

Screenshot 2024-02-16 at 6 11 02 PM

Closing because unneeded for now.