PlayerControl.Exiled() called twice

[yukieiji]

Describe the bug PlayerControl.Exiled() is called twice when the player is exiled I checked with Skeld and AirShip.

To Reproduce Steps to reproduce the behavior:

1. Play Skeld or AirShip
2. Exiled player

Expected behavior It seems correct that this process is called only once at the time of exile.

Version (please complete the following information):

• Among Us: 2023.7.12
• Submerged: 2023.07.24 and 2023.08.02

Log file LogOutput.log "[Info :Extreme Roles] Call exiled!!!!!" (PlayerControl.Exied() is called) is called twice, this is the log of one exiled.

Additional context I have another mod installed, but uninstalling only the submerged fixed this problem

[yukieiji]

I applied a Patch to ExileControllerPatches.BeginPatch and this issue no longer occurs. ExileController.Begin to display the number of people in other teams in my mod, so it seems that there was a conflict and this issue was occurring.

[Alexejhero]

Okay I understand the problem. However we need that patch because otherwise the exile text isn't properly displayed sometimes...

[Alexejhero]

Can this issue be closed then?

[yukieiji]

I have confirmed that even with only the Begin patch of my mod working, in rare cases, the exile text is not displayed. I have also confirmed that it always disappears after it is no longer displayed.

[Alexejhero]

So in order to facilitate mod compatibility, I've taken out the Submerged patch on ExileController begin into its own method which you can patch instead of the original ExileController.Begin if Submerged is installed. How is that?

[Alexejhero]

So mod devs would patch this method with the same patch that you would apply to ExileController.Begin

[yukieiji]

I have the following patched in my mod, how do I patch it?

[Alexejhero]

Something like this maybe?

[Alexejhero]

If you call Apply from the mod's entry point it might load before submerged and not detect it, in this case you can either make your mod load after submerged by adding [BepInDependency("Submerged", BepInDependency.DependencyFlags.SoftDependency)] to your plugin class or by calling Apply at a later point, such as a patch in AmongUsClient.Awake

[yukieiji]

Thank you, I would think fixes are done with this commit.

[Alexejhero]

I hope this is an acceptable compromise I don't know what else I could do to improve compatibility here.

I thought about checking ExileController.Begin for patches from other mods and unpatching them from there and instead repatching them on ExileControllerPatches.ExileController_Begin, but that's not possible because in one case ExileController is __instance and in the other case its HarmonyArgument(0)

[yukieiji]

In v2024.8.1 this patch has been removed, is it no longer necessary to do anything?

[Alexejhero]

Yeah you don't need to worry about this anymore, it should work just like any other map.