search

SubmergedAmongUs / Submerged

An Among Us mod which adds a new underwater map
Other
102 stars 17 forks source link

Resource.Embedder package requires github authentication to download #141

Open Pietrodjaowjao opened 6 months ago

Pietrodjaowjao commented 6 months ago

image Translation: Mandatory proxy authentication

If i click cancel, it will just throw NU1301 for nuget.pkg.github.com/SubmergedAmongUs/index.json

Pietrodjaowjao commented 6 months ago

Solution: Remove repo from nuget.config, then git clone Resource.Embedder into the csproj folder

Alexejhero commented 6 months ago

Submerged uses a custom version of the Resource.Embedder package, which is hosted here on the GitHub package registry.

The GitHub package registry annoyingly requires you to sign in in order to download any packages. You have to enter your GitHub credentials there. If you are using two-factor authentication, then you need to generate a personal access token and use that as your password. This is then saved in your Windows Credential Manager. This is the same credential that is used when performing git operations from the command line (I am pretty sure), so if you're signed into git in the command line then I don't think this pop-up will occur.

image

Alexejhero commented 6 months ago

I dislike this as well but I'm not sure what other alternatives there are. Maybe clone the Resource.Embedder package as a submodule, or get rid of it entirely from the codebase. I will think about it.

Pietrodjaowjao commented 6 months ago

maybe merge Resource.Embedder into the repo?

AmongUsafk commented 6 months ago

Hi, I encountered this error yesterday, in Credential Manager Username Case I have to write my name from my github account or the token?

Alexejhero commented 6 months ago

If you do NOT have two-factor authentication installed: enter your GitHub username and password If you DO have two-factor authentication installed: Generate a personal access token by following this guide, enter your GItHub username in the username field and enter the personal access token instead of the password.

AmongUsafk commented 6 months ago

Thx :heart:

AmongUsafk commented 6 months ago

Is Possible to set that in a GitHub Codespace i use it a lot ? or i Need to use vs code desktop ?

Alexejhero commented 6 months ago

If you use a GitHub Codespace, it probably uses git credential-manager instead of the Windows Credential Manager. Maybe look it up and see if you can set it up using that

Pietrodjaowjao commented 6 months ago

@Alexejhero Resource.Embedder is not even used in the project at all

Alexejhero commented 6 months ago

It is used, it's imported as a NuGet package.

Pietrodjaowjao commented 6 months ago

i removed it and nothing changed