SubmergedAmongUs / Submerged

An Among Us mod which adds a new underwater map
Other
102 stars 17 forks source link

Unity project: Update minigames to use script injection #158

Closed Alexejhero closed 4 months ago

Alexejhero commented 5 months ago

Currently we use a shitty system of injecting minigames because that was the only way of doing it back when submerged was originally made, this should be swapped out for proper script injection.

While at it, it might be a good idea to play animations by reference using SpriteAnim instead of playing them by name from the animation controller.

Alexejhero commented 4 months ago

Issue identified:

I tried updating one of the minigames to use script injection, but the Il2CppReferenceFields do not copy their value over when copying an existing object with Object.Instantiate, only when instantiating a prefab. I do not know why that is 🤷

This is a problem because in Submerged we clone all of the minigame prefabs when the map is loaded, because otherwise the game randomly crashes when exiting the map or loading the map subsequent times. I've no idea why this is the case but I cba to debug this

As such this whole update thing seems pretty unlikely to be possible for now