SubmergedAmongUs / Submerged

An Among Us mod which adds a new underwater map
Other
102 stars 17 forks source link

Add Setup CI for Submerged #162

Closed AmongUsafk closed 2 months ago

AmongUsafk commented 4 months ago

hi @Alexejhero ,

Related to #149

this pr Implements CI workflow and adds build data file as specified.


if there any thing to change or something else feel free to ask me to do it

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

Alexejhero commented 4 months ago

Thank you so much for the contribution! I'll take a look at this sometime next week. Please remind me if I don't.

AmongUsafk commented 4 months ago

Thank you so much for the contribution! I'll take a look at this sometime next week. Please remind me if I don't.

no problem man i really love the project so much and i will remind you next week if u forgot

AmongUsafk commented 4 months ago

and a lot of contribution is coming soon

AmongUsafk commented 4 months ago

This pull request is not finished yet, automating release artifacts hasn't been implemented. I won't be merging this in until that is added.

ok i will do that

AmongUsafk commented 4 months ago

i have added automating release artifacts but i have a problem in the phase of dotnet build it give 859 error i checked the project is restored if u a know a fix tell me

Alexejhero commented 4 months ago

i have added automating release artifacts but i have a problem in the phase of dotnet build it give 859 error i checked the project is restored if u a know a fix tell me

That's a good point, I guess CI is not possible without adding secrets due to #141. I think I'd wait for #141 to be resolved before adding CI.

AmongUsafk commented 4 months ago

i have added automating release artifacts but i have a problem in the phase of dotnet build it give 859 error i checked the project is restored if u a know a fix tell me

That's a good point, I guess CI is not possible without adding secrets due to #141. I think I'd wait for #141 to be resolved before adding CI.

ok then when the #141 is fixed tell me to fix the ci

Alexejhero commented 2 months ago

Closing this for now, #141 has a very low chance of being resolved in the near future