Open bmcutler opened 1 year ago
Please assign, I'd lile to take this issue @bmcutler
Hi @ShatilKhan
Thank you for your interest in the Submitty open source project. We welcome contributions from new developers! However we do not use the Github issue 'assign' feature for first time prospective contributors.
Please read our documentation on how to to get started with Submitty: https://submitty.org/developer/getting_started/index Specifically in setting up your development environment: https://submitty.org/developer/getting_started/vm_install_using_vagrant And making a pull request: https://submitty.org/developer/getting_started/make_a_pull_request You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue. We also encourage you to join our Zulip server to discuss technical questions: https://submitty.org/index/contact
Describe the bug
2 students planned to work together, but did not make their team before the team lock deadline. They each made their own team.
And they each submitted the same materials to their individual team.
the grader/instructor manually removes student b from team b. And then adds student b to team a. team b has no members and is now not visible in the index of all teams.
the instructor grades all remaining teams.
grading percentage is incomplete. I think the abandoned team might be messing up the statistics.
Also... if the removal of the only team member from a team was a mistake, I don't think the grader/instructor can fix this. Maybe we want to show teams that have no members on the index page. We may want to view any submitted files.
Also, I believe students can leave teams and create or join other teams. So these abandoned teams can be created even without the grader/instructor doing manual actions.
EDITED:
After PR #10210 is merged, we will leave this issue open. Remaining items:
Custom team names do not appear in the Empty Teams section
Empty Teams section do no have a button to view the submission for the abandoned team (if there is a submission for that team).
Team history is broken for empty teams as well
NOTE: Statistics for the gradeable will be incorrect when we have an abandoned team with a submission that is ungraded. But this situation can be resolved either by restoring students to the team (if they removed themselves accidentally) and/or by cancelling the submission so it doesn't appear in the statistics page. We do NOT need to further complicate the statistics by excluding teams with no current members.