SubnauticaModding / QModManager

Config based patch management for Subnautica and Subnautica: Below Zero
https://discord.gg/UpWuWwq
Other
141 stars 51 forks source link

Applying a Regex to trim out the dirty string patterns instead #235

Closed toebeann closed 3 years ago

toebeann commented 3 years ago

Identified a bug with the patch to MirrorInternalLogs:

When a log coming from a BepInEx.Logging.ManualLogSource comes in directly after one of the mid string trims applied in the patch (e.g. "(Filename: xdgodkdgx)", the patch unfortunately appears to trim both the intended line + the line coming from the ManualLogSource, and leaves an empty line behind.

Evidence of this occurring is in the Fast Loading Screen mod. The current release version of QMM for SN.STABLE leaves behind a large amount of empty lines after loading into the game, and Fast Loading Screen's logs are absent.

With the modifications I have made to this patch - which use a Regex to strip out occurrences of the intended string - results in the intended behaviour: the garbage line is removed, but no other logs are affected. I have attached an SN.STABLE build of QMM installer from this branch for your testing.

QModManager_4.1.3_Subnautica_Setup.exe.zip