search

SubnauticaNitrox / Nitrox

An open-source, multiplayer modification for the game Subnautica.
GNU General Public License v3.0
1.74k stars 1.05k forks source link

Clients should disconnect when returning to main menu. #145

Closed djkool closed 6 years ago

djkool commented 6 years ago

Clients should send a manual disconnect packet, or at least close the socket after exiting to the main menu. I've notice the server not seeing the player disconnect until after they completely closes the game.

MadMaxOfYore commented 6 years ago

Yes - that is a bug that I introduced recently. I will be fixing it in my next PR and should be landing in next few days.

Apologies for any inconvenience, and thank you for taking time to report the issue.

MadMaxOfYore commented 6 years ago

159 fixes this issues. Users will now log out of the server and will no longer "linger" if they exit the game and leave the client running.

(This is not available yet. It still needs to go through the review/merge process, but a fix is imminent.)

However, it should be noted that users should shut down their client prior to joining a new game. We still have some refactoring to do in order to remove some state caching that is occurring where it should not be. That is not likely to happen until after (or at least very near) an initial alpha build is released to the public - so we thank you for you patience and understanding while we work towards that end.

Does this resolve your issue? If it does, then we'd thank you to go ahead and close this ticket.

Thanks! MadMax

MadMaxOfYore commented 6 years ago

Closing as I assume that the OP is not monitoring this thread.

djkool commented 6 years ago

I am monitoring. I was just waiting until the PR was accepted and the changes were in a master build where it could be tested before I closed.