search

SubstituteR / Pokesposed

12 stars 2 forks source link

Randomize stationary position #16

Closed azgul closed 8 years ago

azgul commented 8 years ago

Hey!

It seemed too suspicious to keep reporting the same position when staying stationary (i.e. camping at lures). So I randomized that part. I also cleaned up the project because it wouldn't compile as it was. Now it has a proper project structure like any other Android app.

If you want me to make the randomization configurable, let me know.

SubstituteR commented 8 years ago

Hey thanks!
I've been a little occupied with life recently, so I haven't been able to work on this project for a while. I will check this and if all looks right I'll merge it directly in and put up a new build on the beta branch on the Xposed Repo.

SubstituteR commented 8 years ago

I noticed that you've created a function for generating a new latlng. Could you consider using the LatLngFromLatLng function? You can generate a position using bearing (0-359 degrees) and a distance in km.

azgul commented 8 years ago

Aha. I didn't realize that that was what it was doing. I suck at maths too ;) So to retain the same logic with that function I would call it with a very low randomized distance as well as randomized bearing, correct?

SubstituteR commented 8 years ago

Yes, pick a bearing at random and a distance at random, min/max for bearing is 0-360 and I'd limit distance to a few meters at most.

SubstituteR commented 8 years ago

Issue not fixed or updated. Closing.