AurelienGasser
commented
3 years ago LGTM :+1:
- You need to bump the chart version (
Chart.yaml) since there's a modification of one of the template files of the chart - Nit: IMO it would be clearer (and could potentially help debugging) if the files (e.g.
chaincode.approve) always included the chaincode name and version (e.g.chaincode_{{ .name }}_{{ .version }}.approve
Due to way conditions were written, there was an approval issued on each iteration (approximately every 10s). This was generating a new transaction each time, increasing block height although there was no real chaincode usage.
With these changes, the loop body is only executed when the condition is met.