Substra / hlf-k8s

Initializes an Hyperledger Fabric network (orchestrator distributed mode)
https://docs.substra.org
Apache License 2.0
31 stars 20 forks source link

Warn user if persistence is disabled #118

Closed Kelvin-M closed 3 years ago

Kelvin-M commented 3 years ago

With https://helm.sh/docs/topics/charts/#schema-files, we need to warn user if they deploy hlf-k8s without persistence over peer, orderer, ca, couchdb !

Kelvin-M commented 3 years ago

It seems to be complicated to do so with json schema. We can alternatively switch persistence true by default like bitnami charts like https://github.com/bitnami/charts/tree/master/bitnami/rabbitmq. What do you think ?

inelgnu commented 3 years ago

@Kelvin-M I think it's more safe to enable it by default. So 👍 for me.