Substra / hlf-k8s

Initializes an Hyperledger Fabric network (orchestrator distributed mode)
https://docs.substra.org
Apache License 2.0
31 stars 20 forks source link

Helm apiv2 and dropping nginx-ingress dependency #124

Closed AlexandrePicosson closed 3 years ago

AlexandrePicosson commented 3 years ago

Description

Change the chart api version as everyone should have done the move from Helm2 to Helm3. Drop the nginx-ingress dependency. Add some annotations to the chart to have the fancy and easily accessible CHANGELOG displayed on https://artifacthub.io/.

I upgraded the version as if it was a breaking change but let me know if you don't think that is appropriate.

Motivation and Context

Since #82 we made the move from Helm2 to helm3 but we never updated the chart API version to definitely remove the possibility to use Helm2. As Helm2 is now legacy there is no reason to not keep using the old api version.

And for removing the nginx-ingress dependency, we think it was never used. A lot of peoples deploys their own ingress controller in production, or use the one provided by minikube or other softwares locally.

How Has This Been Tested?

Running the various skaffold files.

Types of changes

Checklist: